RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node [v2]

[Emanuel Peter]

On Tue, 31 Oct 2023 10:06:58 GMT, Eric Liu <eliu at openjdk.org> wrote:

>> src/hotspot/share/opto/matcher.cpp line 2800:
>> 
>>> 2798:   BasicType bt = vector_element_basic_type(n);
>>> 2799:   assert(bt != T_CHAR, "char is not allowed in vector");
>>> 2800:   return is_subword_type(bt) || bt == T_INT;
>> 
>> I suggest you create a `is_non_long_integral_vector` in `src/hotspot/share/utilities/globalDefinitions.hpp`, next to `is_integral_type`.
>
> This method is used only for matcher.  We can do this if  there were more usages of `is_subword_type(bt) || bt == T_INT`.

I would do it now. An other person may not see your code and not do the refactoring.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14830#discussion_r1377361032