RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v3]

Daniel Lundén duke at openjdk.org
Tue Oct 31 10:25:30 UTC 2023


On Tue, 31 Oct 2023 10:06:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Ah, good point. So, essentially, the `if (conv)` in my fix will only check from the ConvI2L last visited by the first call to `ConstraintCastNode::visit_uncasted_uses` (which may not be the one leading to AndL).
>
> Exactly! Or it may be one, but there are others. Actually, it would be interesting to see if we can find an example. Maybe too much work thouch.

Fix pushed, would be great if you could have another look @eme64. I'll try to construct an example as well where my first fix fails.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1377364621


More information about the hotspot-compiler-dev mailing list