RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v3]

[Daniel Lundén]

On Tue, 31 Oct 2023 10:37:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix push_and to step through all ConvI2L children
>
> test/hotspot/jtreg/compiler/ccp/TestShiftConvertAndNotification.java line 31:
> 
>> 29:  *                   -XX:+StressIGVN -XX:-CICompileOSR -Xcomp
>> 30:  *                   -XX:CompileCommand=compileonly,TestShiftConvertAndNotification::test
>> 31:  *                   compiler.ccp.TestShiftConvertAndNotification
> 
> How long does this test take to execute? `-XX:RepeatCompilation=1000` could make this test slow.
> 
> Do you need `-Xcomp`, or is `-Xbatch` sufficient? Or even without?
> 
> Also: I would add another `@run` description which runs the test with no flags, or at most `-Xcomp`. It has happened often that this triggers new bugs, maybe in combination with other flags set from the outside. And for that it is good to have a run with very few or better no flags/args at all. And the testing people like it if you don't just have multiple `@run` statements, so just duplicate the whole:
> 
> 
> /*
>  * @test
>  * ..
>  */

Yes, I need to tweak this. The failure is, for some reason, not appearing when run through jtreg. I'll get back to you (also with answers to your other questions).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1377441413