RFR: 8319165: hsdis binutils: warns on empty string as option string

[Robbin Ehn]

On Tue, 31 Oct 2023 14:15:16 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> insn_options[0] is set to empty string if there is no options (NULL or empty strings).
>> Checking it for empty string should cover both cases, caller option is NULL or caller option is empty string.
>> 
>> Tested hsdis no longer gives me the warning.
>
> src/utils/hsdis/binutils/hsdis-binutils.c line 340:
> 
>> 338:                                  native_bfd,
>> 339:                                  /* On some archs we get warnings, if we pass empty options */
>> 340:                                  (app_data->insn_options[0] == '\0') ? NULL : app_data->insn_options);
> 
> What if `caller_options == NULL`?

The parse_caller_options handles the NULL case, so I forgot about the early bailout.

  for (p = caller_options; p != NULL; ) {
  }
  *iop = '\0';


Sorry.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16433#discussion_r1377684469