RFR: 8319165: hsdis binutils: warns on empty string as option string

[Robbin Ehn]

On Tue, 31 Oct 2023 14:30:26 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/utils/hsdis/binutils/hsdis-binutils.c line 340:
>> 
>>> 338:                                  native_bfd,
>>> 339:                                  /* On some archs we get warnings, if we pass empty options */
>>> 340:                                  (app_data->insn_options[0] == '\0') ? NULL : app_data->insn_options);
>> 
>> What if `caller_options == NULL`?
>
> The parse_caller_options handles the NULL case, so I forgot about the early bailout.
> 
>   for (p = caller_options; p != NULL; ) {
>   }
>   *iop = '\0';
> 
> 
> Sorry.

Sorry again, long day:

  struct hsdis_app_data app_data;
  memset(&app_data, 0, sizeof(app_data));

I knew I saw that somewhere.
So if we don't parse at all (caller options NULL) it should be empty string in insn_options.

That is the way we handle caller option NULL, no ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16433#discussion_r1377704342