RFR: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint [v10]
Vladimir Kempik
vkempik at openjdk.org
Sun Sep 3 17:24:39 UTC 2023
On Fri, 1 Sep 2023 07:13:57 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Ilya Gavrilin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix typo in c2_MacroAssembler_riscv.cpp
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1383:
>
>> 1381:
>> 1382: assert_different_registers(dst, src);
>> 1383: assert_different_registers(tmp1, tmp2, tmp3);
>
> Suggestion: `assert_different_registers(dst, src, tmp1, tmp2, tmp3);`
I doubt we can use assert_different_registers with different typos of register classes ( Register and FloatRegister here)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14991#discussion_r1314291535
More information about the hotspot-compiler-dev
mailing list