RFR: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint [v10]

Fei Yang fyang at openjdk.org
Mon Sep 4 00:26:41 UTC 2023


On Sun, 3 Sep 2023 17:22:07 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1383:
>> 
>>> 1381: 
>>> 1382:   assert_different_registers(dst, src);
>>> 1383:   assert_different_registers(tmp1, tmp2, tmp3);
>> 
>> Suggestion: `assert_different_registers(dst, src, tmp1, tmp2, tmp3);`
>
> I doubt we can use assert_different_registers with different types of register classes ( Register and FloatRegister here)

That's right. Thanks for pointing this out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14991#discussion_r1314342742


More information about the hotspot-compiler-dev mailing list