RFR: 8315369: [JVMCI] failure to attach to a libgraal isolate during shutdown should not be fatal

[Tom Rodriguez]

On Fri, 1 Sep 2023 17:02:51 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR moves handling of errors in some JVMCIEnv constructors to the caller. This avoids VM crashes in contexts where errors are recoverable, such as the problem of running out of file descriptors described in the JBS issue for this PR.

looks ok to me.

src/hotspot/share/jvmci/jniAccessMark.inline.hpp line 47:

> 45:     _ttnfv(thread), _hm(thread) {
> 46:     _env = jvmci_env->_env;
> 47:     assert(jvmci_env->init_error() == JNI_OK, "invalid JVMCIEnv (err: %d)", jvmci_env->init_error());

maybe this should be a guarantee?

-------------

Marked as reviewed by never (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15542#pullrequestreview-1608850993
PR Review Comment: https://git.openjdk.org/jdk/pull/15542#discussion_r1314495111