RFR: 8315637: JDK-8314249 broke libgraal

[Matias Saavedra Silva]

On Tue, 5 Sep 2023 23:20:17 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this change in JVMCI. The actual functional change is essentially the same as the patch provided by @dougxc in [JDK-8315637](https://bugs.openjdk.org/browse/JDK-8315637) -- convert the `rawIndex` to `cpci` only if the bytecode is INVOKE{VIRTUAL,SPECIAL,STATIC,INTERFACE}.
> 
> The rest of the changes is to rename the parameters from `rawIndex` to `which`, so we know the correct type of index is passed. I also added a test case.
> 
> (This code should be much simpler after [JDK-8301993](https://bugs.openjdk.org/browse/JDK-8301993) is complete: we won't have `cpci` anymore and all `which` can be replaced with `rawInex`).

Looks good, thanks for this change! I have one small question, but otherwise approved.

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstantPool.java line 407:

> 405:      * @return name as {@link String}
> 406:      */
> 407:     private String getNameOf(int rawIndex, int opcode) {

This method, and `getSignatureOf()` seem to be unused but is it possible that they could have use in the future?

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15575#pullrequestreview-1614183966
PR Review Comment: https://git.openjdk.org/jdk/pull/15575#discussion_r1317812516