RFR: 8314838: 3 compiler tests ignore vm flags
Evgeny Astigeevich
eastigeevich at openjdk.org
Thu Sep 7 11:53:38 UTC 2023
On Thu, 7 Sep 2023 07:41:44 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:
> For the compiler tests in question this PR:
>
> - replaces all calls to `ProcessTools.createJavaProcessBuilder` with another method, the `createTestJvm`, which prepends given arguments with what was passed to the enclosing test. The change therefore...
> - makes sure the external arguments aren't ignored and are used for creating the inner JVM;
> - adds `@requires` guards in some places - where the test explicitly controls the Tiered Compilation, for example.
>
> Testing: a local and a CI run, no failures registered.
lgtm
-------------
Marked as reviewed by eastigeevich (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15609#pullrequestreview-1615253125
More information about the hotspot-compiler-dev
mailing list