RFR: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments [v3]

Sacha Coppey duke at openjdk.org
Thu Sep 7 12:10:34 UTC 2023


On Thu, 7 Sep 2023 11:53:48 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Sacha Coppey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add more details to the documentation and add a pseudo code example for BootstrapMethodInvocation usage
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ConstantPool.java line 145:
> 
>> 143:      *     cpi = staticArguments.get(1).asInt();
>> 144:      *     for (int i = 0; i < argCount; ++i) {
>> 145:      *         arguments[i] = lookupConstant(cpi, i);
> 
> What `lookupConstant` method is this?
> Where is the usage of the new `bootstrapArgumentIndexAt` method?

I made a mistake sorry, it is now correct.
The idea is to use `bootstrapArgumentIndexAt` to obtain the constant pool index of the static argument and use it to call `ConstantPool.lookupConstant(int cpi, boolean resolve)` to get the constant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15588#discussion_r1318505222


More information about the hotspot-compiler-dev mailing list