RFR: 8315637: JDK-8314249 broke libgraal

Ioi Lam iklam at openjdk.org
Thu Sep 7 18:29:40 UTC 2023


On Wed, 6 Sep 2023 07:01:16 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Please review this change in JVMCI. The actual functional change is essentially the same as the patch provided by @dougxc in [JDK-8315637](https://bugs.openjdk.org/browse/JDK-8315637) -- convert the `rawIndex` to `cpci` only if the bytecode is INVOKE{VIRTUAL,SPECIAL,STATIC,INTERFACE}.
>> 
>> The rest of the changes is to rename the parameters from `rawIndex` to `which`, so we know the correct type of index is passed. I also added a test case.
>> 
>> (This code should be much simpler after [JDK-8301993](https://bugs.openjdk.org/browse/JDK-8301993) is complete: we won't have `cpci` anymore and all `which` can be replaced with `rawInex`).
>
> Thanks for the extra cleanup and tests.

Thanks @dougxc and @matias9927 for the review. The new code passed tiers 1 and 2. I also successfully built libgraal with this patch.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15575#issuecomment-1710598327


More information about the hotspot-compiler-dev mailing list