RFR: 8314452: Explicitly indicate inlining success/failure in PrintInlining [v4]

[Vladimir Kozlov]

On Thu, 7 Sep 2023 10:40:12 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> This patch proposes to add a `+` or `-` to messages produced by `PrintInlining`, to indicate whether inlining succeeded or failed. This makes it easier to find inlining failures in an inlining trace, without having to rely on the message to figure out whether inlining succeeded or failed. Looking at inlining failures is often useful for diagnosing the results of benchmarks, but it can be hard to find inlining failures in lengthy traces.
>> 
>> A sample of what this looks like:
>> 
>> 
>>                             +@ 0   java.lang.foreign.Arena::ofConfined (10 bytes)   inline (hot)
>>                               +@ 0   java.lang.Thread::currentThread (0 bytes)   (intrinsic)
>>                               +@ 3   jdk.internal.foreign.MemorySessionImpl::createConfined (9 bytes)   inline (hot)
>>                                 +@ 5   jdk.internal.foreign.ConfinedSession::<init> (18 bytes)   inline (hot)
>>                                   +@ 6   jdk.internal.foreign.ConfinedSession$ConfinedResourceList::<init> (5 bytes)   inline (hot)
>>                                     +@ 1   jdk.internal.foreign.MemorySessionImpl$ResourceList::<init> (5 bytes)   inline (hot)
>>                                       +@ 1   java.lang.Object::<init> (1 bytes)   inline (hot)
>>                                   +@ 9   jdk.internal.foreign.MemorySessionImpl::<init> (20 bytes)   inline (hot)
>>                                     +@ 1   java.lang.Object::<init> (1 bytes)   inline (hot)
>>                               +@ 6   jdk.internal.foreign.MemorySessionImpl::asArena (9 bytes)   inline (hot)
>>                                 +@ 5   jdk.internal.foreign.MemorySessionImpl$1::<init> (10 bytes)   inline (hot)
>>                                   +@ 6   java.lang.Object::<init> (1 bytes)   inline (hot)
>>                             -@ 8   java.lang.foreign.SegmentAllocator::allocate (24 bytes)   already compiled into a big method
>> 
>> 
>> Using `grep`/`sls` to find inlining failures:
>> 
>> 
>>> Get-Content inlining_trace.txt | sls '-@'
>>                             -@ 8   java.lang.foreign.SegmentAllocator::allocate (24 bytes)   already compiled into a big method
>>                             -@ 34   java.lang.foreign.SegmentAllocator::allocate (24 bytes)   already compiled into a big method
>>                                         -@ 19   java.lang.invoke.MethodHandle::linkToNative(JJJL)D (0 bytes)   native call
>>                                     -@ 95   java.lang.foreign.Arena::cl...
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix more tests

Looks good. Thank you for finding and fixing affected tests.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15315#pullrequestreview-1616020131