RFR: 8314838: 3 compiler tests ignore vm flags [v2]
Vladimir Kozlov
kvn at openjdk.org
Thu Sep 7 19:14:39 UTC 2023
On Thu, 7 Sep 2023 18:49:15 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:
>> For the compiler tests in question this PR:
>>
>> - replaces all calls to `ProcessTools.createJavaProcessBuilder` with another method, the `createTestJvm`, which prepends given arguments with what was passed to the enclosing test. The change therefore...
>> - makes sure the external arguments aren't ignored and are used for creating the inner JVM;
>> - adds `@requires` guards in some places - where the test explicitly controls the Tiered Compilation, for example.
>>
>> Testing: a local and a CI run, no failures registered.
>
> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
>
> Use vm.simpleArch instead of the os.arch
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15609#pullrequestreview-1616087683
More information about the hotspot-compiler-dev
mailing list