RFR: 8315948: JDK-8315818 broke Xcomp on libgraal
Doug Simon
dnsimon at openjdk.org
Fri Sep 8 18:34:04 UTC 2023
On Fri, 8 Sep 2023 18:24:35 GMT, Tom Rodriguez <never at openjdk.org> wrote:
>> This PR fixes a regression caused by [JDK-8315818](https://bugs.openjdk.org/browse/JDK-8315818). Libgraal must not unblock a thread waiting on a blocking compilation, even if libgraal itself is not yet initialized. Initialization of libgraal is not prone to the same initialization deadlocks that jargraal can cause.
>
> src/hotspot/share/compiler/compileBroker.cpp line 1250:
>
>> 1248: }
>> 1249: } else {
>> 1250: // In libjvmci, JVMCI initialization should not deadlock with other threads
>
> Can't this comment just go before the guarding if? An empty else at the every end is harder to connect with the guarding condition.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15643#discussion_r1320207198
More information about the hotspot-compiler-dev
mailing list