RFR: 8312332: C2: Refactor SWPointer out from SuperWord [v3]

Emanuel Peter epeter at openjdk.org
Mon Sep 11 07:25:40 UTC 2023


On Mon, 11 Sep 2023 06:51:03 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move the cache of _pre_loop_end to CountedLoopNode
>
> src/hotspot/share/opto/loopnode.hpp line 236:
> 
>> 234: 
>> 235:   // Cached CountedLoopEndNode of pre loop for main loops
>> 236:   CountedLoopEndNode* _pre_loop_end;
> 
> Is it safe to cached this node? What happens if the node were ever to be replaced?

Ah, we need to access it via `pre_loop_end()` which has asserts that check the consistency. Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15013#discussion_r1321079691


More information about the hotspot-compiler-dev mailing list