RFR: 8315801: [PPC64] JNI code should be more similar to the Panama implementation [v3]

Martin Doerr mdoerr at openjdk.org
Mon Sep 11 15:33:24 UTC 2023


> This PR removes writing parameters to stack which are passed in registers. (See JBS issue for more details.) This allows us to get rid of the extra parameter for `c_calling_convention`.
> 
> We can also remove the extra space for the Parameter Save Area in some ABIv2 cases (ppc64le). Note that JNI and runtime calls don't support VarArgs (except as array object for JNI), so this optimization is valid (unlike in downcalls for Panama).
> 
> Tests have passed on linux ppc64 and ppc64le and AIX.

Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:

  Introduce constant float_on_stack_offset_in_bytes and use it for interpreter, c_calling_convention and Panama.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15599/files
  - new: https://git.openjdk.org/jdk/pull/15599/files/4ab5372f..65c16e20

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15599&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15599&range=01-02

  Stats: 43 lines in 5 files changed: 9 ins; 29 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/15599.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15599/head:pull/15599

PR: https://git.openjdk.org/jdk/pull/15599


More information about the hotspot-compiler-dev mailing list