RFR: 8315801: [PPC64] JNI code should be more similar to the Panama implementation [v4]
Martin Doerr
mdoerr at openjdk.org
Mon Sep 11 15:53:41 UTC 2023
> This PR removes writing parameters to stack which are passed in registers. (See JBS issue for more details.) This allows us to get rid of the extra parameter for `c_calling_convention`.
>
> We can also remove the extra space for the Parameter Save Area in some ABIv2 cases (ppc64le). Note that JNI and runtime calls don't support VarArgs (except as array object for JNI), so this optimization is valid (unlike in downcalls for Panama).
>
> The offset of floats on stack can be put into a constant and used by interpreter, `c_calling_convention` and Panama. This resolves a Panama "todo".
>
> Tests have passed on linux ppc64 and ppc64le and AIX.
Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
Move new constant into Argument class.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15599/files
- new: https://git.openjdk.org/jdk/pull/15599/files/65c16e20..cd250ebb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15599&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15599&range=02-03
Stats: 22 lines in 5 files changed: 9 ins; 9 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/15599.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15599/head:pull/15599
PR: https://git.openjdk.org/jdk/pull/15599
More information about the hotspot-compiler-dev
mailing list