RFR: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector [v2]

Emanuel Peter epeter at openjdk.org
Tue Sep 12 12:28:05 UTC 2023


On Tue, 12 Sep 2023 10:43:37 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename ids
>
> test/hotspot/jtreg/compiler/loopopts/superword/TestUnorderedReduction.java line 77:
> 
>> 75:             case "Vanilla-Aligned"           -> { framework.addFlags("-XX:+AlignVector"); }
>> 76:             case "MaxVectorSize16-Unaligned" -> { framework.addFlags("-XX:-AlignVector", "-XX:MaxVectorSize=16"); }
>> 77:             case "MaxVectorSize32-Aligned"   -> { framework.addFlags("-XX:+AlignVector", "-XX:MaxVectorSize=32"); }
> 
> Since `AlignVector` and `MaxVectorSize` are C2 flags, you should add a `@requires vm.compiler2.enabled` to all `@test` definitions.

good idea, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15654#discussion_r1322955228


More information about the hotspot-compiler-dev mailing list