RFR: 8312332: C2: Refactor SWPointer out from SuperWord [v3]

[Pengfei Li]

On Tue, 12 Sep 2023 16:51:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> In general it looks good. I just want that you add more description.
>
> And I have question. Part of code is under "#ifndef PRODUCT". Did you build "optimized" VM to make sure it works?

@vnkozlov, I just checked with CompilerDirectives and got the same tracing output between "fastdebug" build and "optimized" build, and no tracing output is seen for "release" build.

> src/hotspot/share/opto/vectorization.hpp line 31:
> 
>> 29: #include "opto/loopnode.hpp"
>> 30: 
>> 31: // ----------------------------------VPointer----------------------------------
> 
> We stop using such lines - there was cleaning RFE to remove them.

Fixed

> src/hotspot/share/opto/vectorization.hpp line 32:
> 
>> 30: 
>> 31: // ----------------------------------VPointer----------------------------------
>> 32: // Information about an address for dependence checking and vector alignment
> 
> I am fine with using VPointer name but I think you need to add more description here to avoid confusion.
> 
> May be add a general description what is in this file: "for shared logics and utilities for C2's auto-vectorization".

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15013#issuecomment-1717317480
PR Review Comment: https://git.openjdk.org/jdk/pull/15013#discussion_r1324269957
PR Review Comment: https://git.openjdk.org/jdk/pull/15013#discussion_r1324269642