RFR: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments [v7]

Doug Simon dnsimon at openjdk.org
Wed Sep 13 14:02:43 UTC 2023


On Wed, 13 Sep 2023 13:51:02 GMT, Sacha Coppey <duke at openjdk.org> wrote:

>> Sacha Coppey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use lookupConstant instead of lookupConstantInPool in CachedBSMArgs.get
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstantPool.java line 573:
> 
>> 571:                     res = runtime().getReflection().forObject(type);
>> 572:                 } else {
>> 573:                     res = JavaConstant.forInt(argCpi);
> 
> Based on my understanding and my testing, this can only be reached for `CONSTANT_Dynamic` constant pool entries, as other types of entries should resolve even with `resolve = false`. Am I correct or am I missing some edge cases?

I think that's right based on the spec for `ConstantPool.lookupConstant`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15588#discussion_r1324563012


More information about the hotspot-compiler-dev mailing list