RFR: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments [v5]
Doug Simon
dnsimon at openjdk.org
Wed Sep 13 14:20:44 UTC 2023
On Wed, 13 Sep 2023 14:13:16 GMT, Sacha Coppey <duke at openjdk.org> wrote:
>> Is the assertion in code that can throw exceptions?
>
> The assertion is [here](https://github.com/openjdk/jdk/blob/bd477810b176696e0fd043f5594663ebcf9884cf/src/hotspot/share/oops/constantPool.hpp#L621-L625). I don't think we can throw exception there. I could check the size in `jvmciCompilerToVM.bootstrapArgumentIndexAt`, but it would require a bit of code duplication to obtain it.
Ok. You should just add a note in the javadoc that the result is undefined if `index` is out of bounds. This is all internal API so I assume we can guarantee the value is correct?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15588#discussion_r1324590109
More information about the hotspot-compiler-dev
mailing list