RFR: 8316178: Better diagnostic header for CodeBlobs
Aleksey Shipilev
shade at openjdk.org
Thu Sep 14 08:09:41 UTC 2023
On Wed, 13 Sep 2023 11:52:18 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> I realized that JMH perfasm misses some CodeBlobs, notably C1 RuntimeBlobs. While amending perfasm to capture those, I discovered the header printout for those blobs is not as convenient as for others. Notably, perfasm would like to know where the stub code ends.
>>
>>
>> # Good:
>> StubRoutines::sha512_implCompressMB [0x0000000117da2d80, 0x0000000117da3528] (1960 bytes)
>>
>> # Bad:
>> Decoding RuntimeStub - _complete_monitor_locking_Java 0x0000000117e4fd10
>>
>>
>> After this change, we print this:
>>
>>
>> Decoding RuntimeStub - _complete_monitor_locking_Java 0x0000000114203110 [0x00000001142031c0, 0x0000000114203258] (152 bytes)
>>
>>
>> Note it still prints the (base) stub address. I think it is still useful for debugging. The brackets print the code size, because that is what the decoding block handles: the code.
>
> Looks good to me.
Thanks @TobiHartmann! I think I would need another review before I can integrate.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15708#issuecomment-1718964480
More information about the hotspot-compiler-dev
mailing list