RFR: 8316178: Better diagnostic header for CodeBlobs

Stefan Karlsson stefank at openjdk.org
Fri Sep 15 05:53:41 UTC 2023


On Thu, 14 Sep 2023 19:01:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > > Looks good. One question: did you change `INTPTR_FORMAT` to `PTR_FORMAT` because they are the same but shorter name?
> > 
> > 
> > Muscle memory: when using `p2i` I use `PTR_FORMAT`, so when I rewrote `stub` to `p2i(stub)`, I also changed to `PTR_FORMAT` to match. Not really sure what is our agreed style here, though.
> 
> It looks like we use both evenly so I am fine with this change.

We have been pushing people towards using PTR_FORMAT instead of INTPTR_FORMAT when printing pointers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15708#issuecomment-1720713998


More information about the hotspot-compiler-dev mailing list