RFR: 8316669: ImmutableOopMapSet destructor not called
Vladimir Kozlov
kvn at openjdk.org
Thu Sep 21 20:38:09 UTC 2023
On Thu, 21 Sep 2023 20:08:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> > Thank you for adding the destructor. It should free memory used by _oop_maps.
>
> I can do that, but that would mean that the object would free its own memory it is running on which seems unusal.
>
> Maybe it is best to add a static free_oop_map_set or similar method to ImmutableOopMapSet that frees that memory? Then that class would nominally both allocate and deallocate that object's memory.
>
> What do you think?
Yes, this should work too. I want ImmutableOopMapSet class handle creation and desctruction instead of Codeblob.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15862#discussion_r1333574891
More information about the hotspot-compiler-dev
mailing list