RFR: 8316669: ImmutableOopMapSet destructor not called [v2]

Tobias Hartmann thartmann at openjdk.org
Fri Sep 22 08:11:17 UTC 2023


On Fri, 22 Sep 2023 07:29:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this addition to call the destructor of `ImmutableOopMapSet` before its memory is deleted. There is no functional problem as the destructor is empty, but it is surprising to free new'ed objects without calling its destructor.
>> 
>> Testing: gha
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jvernee review

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15862#pullrequestreview-1639383078


More information about the hotspot-compiler-dev mailing list