Integrated: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs

Tobias Hartmann thartmann at openjdk.org
Fri Sep 22 08:34:20 UTC 2023


On Wed, 13 Sep 2023 11:50:03 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> We hit an assert during loop opts because the control input fed into `must_be_not_null` in `LibraryCallKit::inline_native_notify_jvmti_funcs` is wrong. The problem is that control is obtained from the `GraphKit` while it's been updated via the `IdealKit`. I simply moved the `must_be_not_null` out of the if branch and to before `IdealKit` creation, similar to what we do for other intrinsics.
> 
> The original reproducer requires JFR and changes to core libraries (see JBS for details) and I was not able to extract a standalone reproducer. I don't think it's worth it because the required core libraries changes will be integrated separately and then the existing test will trigger the issue (with JFR).
> 
> Thanks,
> Tobias

This pull request has now been integrated.

Changeset: 4b654839
Author:    Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4b65483921ddadc9dd6c6e6c59b541673e3d2d88
Stats:     6 lines in 1 file changed: 2 ins; 4 del; 0 mod

8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs

Reviewed-by: roland, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/15713


More information about the hotspot-compiler-dev mailing list