Integrated: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
Xin Liu
xliu at openjdk.org
Fri Sep 22 08:38:22 UTC 2023
On Fri, 22 Sep 2023 01:53:24 GMT, Xin Liu <xliu at openjdk.org> wrote:
> This is a follow-up of JDK-8310220. hotspot C2 only emits IR per bytecode to IGV when level = 5.
>
> Currently, we conservatively check C->should_print_igv(1) in Parse::do_one_bytecode(). It's wasteful when level>1 and <= 4. We evaluate `jio_snprintf(buffer, sizeof(buffer), "Bytecode %d: %s", bci(), Bytecodes::name(bc()))` for each bytecode but emit nothing.
>
> We should use the same level(5) in those 2 places.
This pull request has now been integrated.
Changeset: bd2439f3
Author: Xin Liu <xliu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/bd2439f3fc824339c9abc10fe7f7b59eab3d9e21
Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
Reviewed-by: chagedorn, thartmann
-------------
PR: https://git.openjdk.org/jdk/pull/15878
More information about the hotspot-compiler-dev
mailing list