RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v2]

[Tobias Hartmann]

On Thu, 21 Sep 2023 10:44:28 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> I don't think splitting these 2 would ease reviewing

Okay, thanks for the details! Let's leave it as is then.

> Yes the sign of the result is determined by its sign bit so this patch does solve that issue.

I closed [JDK-8311597](https://bugs.openjdk.org/browse/JDK-8311597) as duplicate.

> I think the patch fully covers John's prototype

Okay, I leave it to @rose00 to decide if [JDK-8001436](https://bugs.openjdk.org/browse/JDK-8001436) should be closed as duplicate then.

> it simply moves the complexity and burden of correctness from xmeet where branching on the _dual field is pretty straightforward to xdual where this representation is a fair leap of faith

Thanks for summarizing. Right, I agree that in this case it's much cleaner to special case the dual types but I don't think that would apply in general to all the types (for example, `TypePtr::meet_instptr`). So this is all about consistency of new changes with existing code and I would prefer consistency over special casing. If we identify improvements to the existing representation of types, that should be done in a separate change and consistently over all types. I'm curious what other reviewers think though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15440#issuecomment-1733079147