Integrated: 8315920: C2: "control input must dominate current control" assert failure

[Roland Westrelin]

On Wed, 13 Sep 2023 14:35:55 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> The assert fires during range check eliminationin code that was added
> recently. It catches a bug that's been going unnoticed. The `array[0]`
> load of the test case ends up on the exit of the loop above it. After
> pre/main/post loops are created for this loop (the inner loop is
> optimized out), the load is at a region merging control from the just
> created pre/main/post loops but its control (as returned by
> `PhaseIdealLoop::get_ctrl()`) is not updated by pre/main/post loops
> creation code so it's still the exit projection of one of the
> loops. This causes the assert to fire (the load has bad control) when
> RC runs next in the same loop opts pass.
> 
> The current logic for pre/main/post loops creation does update the
> control of nodes on an exit projection but only if the node is
> referenced from some other node in the loop body.
> 
> I think a similar bug with a node assigned control at the exit but not
> pinned is likely to exist. So I doubt simply going over nodes pinned
> at exits during pre/main/post and updating their control is good
> enough. What I propose instead is to `lazy_replace()` the projection
> by the region so that, for all nodes that are assigned the exit as
> control, `get_ctrl()` will then return the region. It's not entirely
> straightforward to implement because the `lazy_replace()` mechanism
> assumes the control being replaced is dead which is not the case
> here. That's why in the patch the exit projection is cloned so the
> existing one is dead and can be used in `lazy_replace()`. This also
> makes the calls to `sink_use()` redundant.

This pull request has now been integrated.

Changeset: 4e1e579e
Author:    Roland Westrelin <roland at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4e1e579e8b916191397fc958df32ac3f6003c791
Stats:     97 lines in 4 files changed: 76 ins; 17 del; 4 mod

8315920: C2: "control input must dominate current control" assert failure

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/15720