RFR: 8315604: IGV: dump and visualize node bottom and phase types [v3]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Tue Sep 26 16:49:30 UTC 2023
On Tue, 26 Sep 2023 12:54:25 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> This is a very nice improvement! The VM changes look good to me.
>
>> This is a very nice improvement! The VM changes look good to me.
>
> Thanks for reviewing, Tobias!
> Thanks for working on this @robcasloz . That’s a feature I was always missing!
>
> Suggestion: I would find it better for the mind to process if the second line has a different font from the first line in a widget. (e.g. different color, like dark gray or italic) What do you think?
>
> E.g. adding the following code in `FigureWidget.java`
>
> ```java
> for (int i=1; i<labelWidgets.size(); i++) {
> labelWidgets.get(i).setFont(Diagram.FONT.deriveFont(Font.ITALIC));
> labelWidgets.get(i).setForeground(Color.DARK_GRAY);
> }
> ```
>
> 
Great suggestion, done, thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15881#issuecomment-1735909513
More information about the hotspot-compiler-dev
mailing list