RFR: 8308994: C2: Re-implement experimental post loop vectorization [v2]

Pengfei Li pli at openjdk.org
Wed Sep 27 22:32:32 UTC 2023


On Mon, 3 Jul 2023 14:51:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address part of comments from Emanuel
>
> src/hotspot/share/opto/vmaskloop.cpp line 64:
> 
>> 62: 
>> 63:   if (!cl->is_valid_counted_loop(T_INT)) {
>> 64:     trace_msg(nullptr, "Loop is not a valid counted loop");
> 
> Would it help to dump the loop head here? Just that one knows which loop is being rejected here?

Done

> src/hotspot/share/opto/vmaskloop.cpp line 68:
> 
>> 66:   }
>> 67:   if (abs(cl->stride_con()) != 1) {
>> 68:     trace_msg(nullptr, "Loop has unsupported stride value");
> 
> Dump loop head and the stride

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14581#discussion_r1338290086
PR Review Comment: https://git.openjdk.org/jdk/pull/14581#discussion_r1338290316


More information about the hotspot-compiler-dev mailing list