RFR: 8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate

[Martin Doerr]

On Mon, 25 Sep 2023 12:13:40 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

> …missing aggregate
> 
> If jcmd users want to print statistical data about a specific property of the code heap (instead of requesting "all"), they first have to aggregate such data. If this step was forgotten, the requested function just returns. This should be improved. 
> 
> ------ Output before enhancement -------- 
> 
>> bin/jcmd <pid> Compiler.CodeHeap_Analytics FreeSpace 
> <pid>: 
> 
> __ CodeHeapStateAnalytics lock wait took 0.000 seconds _________ 
> 
> __ CodeHeapStateAnalytics total duration 0.000 seconds _________ 
> 
> 
> 
> 
> ------ Output after enhancement -------- 
> 
>> bin/jcmd <pid> Compiler.CodeHeap_Analytics FreeSpace 
> <pid>: 
> 
> __ CodeHeapStateAnalytics lock wait took 0.000 seconds _________ 
> 
> No aggregated data available for heap CodeHeap. Run function aggregate first. 
> 
> __ CodeHeapStateAnalytics total duration 0.000 seconds _________ 
> 
> 
> Comments and reviews are very much appreciated.
> Tests (GHA and SAP-internal test suite) pending.

LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15900#pullrequestreview-1648279054