RFR: 8317257: RISC-V: llvm build broken

Vladimir Kempik vkempik at openjdk.org
Thu Sep 28 17:18:21 UTC 2023


On Thu, 28 Sep 2023 15:37:54 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> Please review this small fix to make hotspot compilable with clang on risc-v.
> It supposed to fix next error:
> 
> /home/user/openjdk/jdk/src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp:1518:10: error: call to member function 'null_check' is ambiguous
>       __ null_check(obj);
>       ~~~^~~~~~~~~~
> /home/user/openjdk/jdk/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp:238:16: note: candidate function
>   virtual void null_check(Register reg, int offset = -1);
>                ^
> /home/user/openjdk/jdk/src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.hpp:109:8: note: candidate function
>   void null_check(Register r, Label *Lnull = nullptr) { MacroAssembler::null_check(r); }
>        ^
> 1 error generated.

Thanks for taking a look, also fixed some static_assert being without message, it's c++17 only feature according to clang error

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15965#issuecomment-1739719322


More information about the hotspot-compiler-dev mailing list