RFR: 8317257: RISC-V: llvm build broken [v2]

Fei Yang fyang at openjdk.org
Fri Sep 29 01:17:20 UTC 2023


On Thu, 28 Sep 2023 17:18:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Please review this small fix to make hotspot compilable with clang on risc-v.
>> It supposed to fix next error:
>> 
>> /home/user/openjdk/jdk/src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp:1518:10: error: call to member function 'null_check' is ambiguous
>>       __ null_check(obj);
>>       ~~~^~~~~~~~~~
>> /home/user/openjdk/jdk/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp:238:16: note: candidate function
>>   virtual void null_check(Register reg, int offset = -1);
>>                ^
>> /home/user/openjdk/jdk/src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.hpp:109:8: note: candidate function
>>   void null_check(Register r, Label *Lnull = nullptr) { MacroAssembler::null_check(r); }
>>        ^
>> 1 error generated.
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   align with arm64 and static_assert should have a message if less than c++17

Updated change LGTM. Thanks.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15965#pullrequestreview-1649887658


More information about the hotspot-compiler-dev mailing list