RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture [v2]

Daniel Skantz duke at openjdk.org
Fri Sep 29 07:46:12 UTC 2023


On Wed, 27 Sep 2023 07:09:05 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Daniel Skantz has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - test method name
>>  - whitespace
>>  - whitespace
>>  - platformFeature to platform. Lint docs. Add more tests.
>>  - Add more platforms in IREncodingPrinter.java
>
> That's a useful addition, thanks for working on this!
> 
> I have a couple of comments but otherwise, it looks good!

Thanks @chhagedorn for the suggestion. The preconditions read better after renaming. Going over IR tests and removing @requires fields sounds good in order to run tests on all platforms and to consolidate tests.

Appreciate the review @robcasloz. I rewrote parts of the documentation and added more tests. Since we are implementing functionality that is similar to jtreg `@requires` reusing that implementation could be favorable.

This PR might be ready for another round of reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15938#issuecomment-1740455000


More information about the hotspot-compiler-dev mailing list