RFR: 8315604: IGV: dump and visualize node bottom and phase types [v4]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Fri Sep 29 08:26:12 UTC 2023
On Mon, 25 Sep 2023 07:39:37 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Roberto Castañeda Lozano has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Pretty-print inequalities
>> - Show phase type first, then bottom type if different
>> - Fix simplification of tuple types
>
> That's a nice improvement! Cannot say much about the filter code - maybe someone else should have a look at that as well.
The latest commits change the order and syntax used when displaying both types (when they are available and differ from each other) after offline feedback from @chhagedorn and @tobiasholenstein. See the updated pull request description for details. They also improve the display of tuple types and pretty-print inequalities.
@tobiasholenstein could you please review the IGV parts of this change?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15881#issuecomment-1740501437
More information about the hotspot-compiler-dev
mailing list