RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture [v2]

[Roberto Castañeda Lozano]

On Wed, 27 Sep 2023 12:00:59 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Skantz has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - test method name
>>  - whitespace
>>  - whitespace
>>  - platformFeature to platform. Lint docs. Add more tests.
>>  - Add more platforms in IREncodingPrinter.java
>
> Looks good to me, modulo issues/comments raised by Christian and a few additional minor comments and suggestions.
> 
> It seems the IR test framework's annotation-based precondition language is slowly converging towards jtreg's @requires expressions. In the long run, it would be interesting to investigate whether we could simply reuse the jtreg @requires expression support (as suggested in [JDK-8294279](https://bugs.openjdk.org/browse/JDK-8294279)).

> Appreciate the review @robcasloz. I rewrote parts of the documentation and added more tests.

The new version looks good. Maybe I missed something, but does any of the newly added tests address my suggestion (https://github.com/openjdk/jdk/pull/15938/files#r1338489724) to check that platform preconditions take precedence over VM flags, i.e. VM flags are not even validated if platform preconditions do not hold?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15938#issuecomment-1740763004