RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture [v2]

Daniel Skantz duke at openjdk.org
Fri Sep 29 12:54:16 UTC 2023


On Fri, 29 Sep 2023 11:50:00 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> > Appreciate the review @robcasloz. I rewrote parts of the documentation and added more tests.
> 
> The new version looks good. Maybe I missed something, but does any of the newly added tests address my suggestion (https://github.com/openjdk/jdk/pull/15938/files#r1338489724) to check that platform preconditions take precedence over VM flags, i.e. VM flags are not even validated if platform preconditions do not hold?

Thanks for the review. The intention is that the last four tests in `TestPreconditions.java` test precedence through platform-specific VM flags. As an example `testApplyPlatformSVE` will fail with `Could not find VM flag "UseSVE"` if we remove the `applyIfPlatform` precondition on x64.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15938#issuecomment-1740774352


More information about the hotspot-compiler-dev mailing list