RFR: 8326962: C2 SuperWord: cache VPointer [v3]

[Emanuel Peter]

On Tue, 2 Apr 2024 13:53:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   for_each_mem
>
> src/hotspot/share/opto/vectorization.cpp line 184:
> 
>> 182: }
>> 183: 
>> 184: void VLoopPointers::compute_and_cache() {
> 
> Could be split into something like:
> 
> allocate_pointer_memory(); 
> initialize_pointers();
> trace_pointers();
> 
> where allocate_pointer_memory():
> number_of_pointers = compute_number_of_pointers();
> uint bytes = number_of_pointers * sizeof(VPointer);
> _pointers = (VPointer*)_arena->Amalloc(bytes);

With the new `for_each_mem`, the code is already much easier to read. I don't know if splitting it further would really help now?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18577#discussion_r1548176186