RFR: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V

[Fei Yang]

On Sat, 30 Mar 2024 14:52:31 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

>> Please review this small change fixing an IR matching failure on linux-riscv platform.
>> 
>> JDK-8324655 tries to identify min/max patterns in CMoves and transform them into Min and Max nodes.
>> But architectures like RISC-V doesn't have support of conditional moves at the ISA level for now.
>> So we set ConditionalMoveLimit parameter to 0 for this platform and conditionals moves are emulated
>> with normal compare and branch instructions instead [1]. This is why the IR matching test added by
>> JDK-8324655 fails on this platform. A simple way to fix this would be skip this test for this case.
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L9775
>
> Thank you for fixing this! It looks good to me.

@jaskarth : Thanks! Could we have a Reviewer please? Maybe @TobiHartmann or @chhagedorn : -)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18558#issuecomment-2033572797