RFR: 8326962: C2 SuperWord: cache VPointer [v5]

[Christian Hagedorn]

On Tue, 2 Apr 2024 15:45:47 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/vectorization.hpp line 456:
>> 
>>> 454: // Submodule of VLoopAnalyzer.
>>> 455: // We compute and cache the VPointer for every load and store.
>>> 456: class VLoopPointers : public StackObj {
>> 
>> Nit: Should we call this `VLoopVPointers` to make the link to `VPointers` and not just some pointers?
>
> Hmm. This looks like a general naming question now. My idea is that the `V` at the beginning of the types just is kind of a "namespace", to say that all types are used for `Vectorization`.
> But I guess here we can do it just so everybody knows we are dealing with `VPointers`. I'll make an exception, but don't want to see `V`'s littered everywhere ;)

I agree that we should not start adding `V`'s in between. But for `VPointer`, I think it makes sense since `VPointer` is quite a known name and `LoopPointers` might be misleading. Thanks for making this change!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18577#discussion_r1549025476