RFR: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V
Christian Hagedorn
chagedorn at openjdk.org
Wed Apr 3 07:10:58 UTC 2024
On Sat, 30 Mar 2024 08:49:00 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Please review this small change fixing an IR matching failure on linux-riscv platform.
>
> JDK-8324655 tries to identify min/max patterns in CMoves and transform them into Min and Max nodes.
> But architectures like RISC-V doesn't have support of conditional moves at the ISA level for now.
> So we set ConditionalMoveLimit parameter to 0 for this platform and conditionals moves are emulated
> with normal compare and branch instructions instead [1]. This is why the IR matching test added by
> JDK-8324655 fails on this platform. A simple way to fix this would be skip this test for this case.
>
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L9775
Looks good to me, too!
-------------
Marked as reviewed by chagedorn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18558#pullrequestreview-1975736029
More information about the hotspot-compiler-dev
mailing list