RFR: 8320725: C2: Add "is_associative" flag for floating-point add-reduction [v3]

Bhavana Kilambi bkilambi at openjdk.org
Wed Apr 3 11:12:25 UTC 2024


On Thu, 21 Mar 2024 11:34:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hi, thank you for your comments on this. I personally also feel "is_associative" is a bit non-intuitive as in the reader might have to make the connection between "associativity" and "ordering" compared to the case where we directly use what we intend the variable to do, something like "is_ordered". Would it be okay if I revert this to "requires_strict_order" for the variable and method names that I used in my first commit?
>
> Yes, I think that would be ok.

Thank you. I have reverted to "requires_strict_order" in the new PS.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1549498466


More information about the hotspot-compiler-dev mailing list