RFR: 8328938: C2 SuperWord: disable vectorization for large stride and scale [v4]
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 3 21:50:11 UTC 2024
On Wed, 3 Apr 2024 06:44:33 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/share/opto/vectorization.cpp line 411:
>>
>>> 409: abs(long_stride) >= max_val ||
>>> 410: abs(long_scale * long_stride) >= max_val) {
>>> 411: assert(!valid(), "adr stride*scale is too large");
>>
>> Why you need assert?
>
> If you look a few lines up, you can see that all other "bailouts" also check that the VPointer is invalid. I am simply matching the surrounding code. And it also makes it explicit, that the VPointer will be invalid, which is what I want.
okay
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18485#discussion_r1550551563
More information about the hotspot-compiler-dev
mailing list