RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v10]

Hamlin Li mli at openjdk.org
Thu Apr 4 13:44:34 UTC 2024


> HI,
> Can you have a look at this patch adding some tests for Math.round instrinsics?
> Thanks!
> 
> ### FYI:
> During the development of RoundVF/RoundF, we faced the issues which were only spotted by running test exhaustively against 32/64 bits range of int/long.
> It's helpful to add these exhaustive tests in jdk for future possible usage, rather than build it everytime when needed.
> Of course, we need to put it in `manual` mode, so it's not run when `-automatic` jtreg option is specified which I guess is the mode CI used, please correct me if I'm assume incorrectly.

Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:

  use java library code of Math.round as golden value

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17753/files
  - new: https://git.openjdk.org/jdk/pull/17753/files/962b40e8..a8c4172d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17753&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17753&range=08-09

  Stats: 64 lines in 2 files changed: 56 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/17753.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17753/head:pull/17753

PR: https://git.openjdk.org/jdk/pull/17753


More information about the hotspot-compiler-dev mailing list