RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v9]

Emanuel Peter epeter at openjdk.org
Fri Apr 5 10:15:01 UTC 2024


On Thu, 4 Apr 2024 09:56:28 GMT, Hamlin Li <mli at openjdk.org> wrote:

> > There's no need for randomness or arrays or special values in the 32-bit case. You can, and should, test the entire 32-bit range in a few lines of code by using floatBitsToInt.
> 
> In previous discussion, there are several reasons why it's implemented in this way:
> 
> 1. test the whole range of 32 bits is slow, and even slow for a 64 ranges double.

I guess we could try it for 32 bit floats. But it would take a while. If we can make sure it does not take much more than one minute, we can do that. But of course 64 bit doubles would be infeasible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1553335033


More information about the hotspot-compiler-dev mailing list