RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v14]

[Emanuel Peter]

On Fri, 5 Apr 2024 11:19:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into licm
>>  - @run driver -> @run main
>>  - Add tests for add/sub reassociation
>>  - Merge branch 'master' into licm
>>  - Make inputs deterministic. Make size an arg. Fix comments. Formatting.
>>  - Update test to utilize @setup method for arguments
>>  - Merge branch 'master' into licm
>>  - Add correctness test for some random tests with random inputs
>>  - Add some correctness tests where we do reassociate
>>  - Remove unused TestInfo parameter. Have some tests exit mid-loop.
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/edcbbb75...32cb9c0d
>
> test/hotspot/jtreg/compiler/loopopts/InvariantCodeMotionReassociateAddSub.java line 36:
> 
>> 34:  * @summary Test loop invariant code motion of add/sub through reassociation
>> 35:  * @library /test/lib /
>> 36:  * @run main compiler.c2.loopopts.InvariantCodeMotionReassociateAddSub
> 
> You should use `driver` since we do not want to stress the driver VM with additionally passed VM flags like `-Xcomp` when running IR tests.
> Suggestion:
> 
>  * @run driver compiler.c2.loopopts.InvariantCodeMotionReassociateAddSub

But if we put `driver` here, do the flags get passed to the IR framework test VM?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1553629023