RFR: 8320649: C2: Optimize scoped values [v13]

Roland Westrelin roland at openjdk.org
Fri Apr 5 13:37:49 UTC 2024


On Fri, 5 Apr 2024 13:29:09 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> You seem to do an all-vs-all optimization here, right?
>> Could you do that in a nested loop, and then just dispatch for all combinations:
>> hits-hits
>> hits-get
>> get-hits
>> get-get
>> 
>> Also: is there a reason for the reverse-order?
>
> Regarding the reverse-order: it makes removing the just processed element easier when it's replaced by a dominating node and so is dead. I added a comment for that.

> You seem to do an all-vs-all optimization here, right? Could you do that in a nested loop, and then just dispatch for all combinations: hits-hits hits-get get-hits get-get

I pushed a new commit that implements what you suggest I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1553651292


More information about the hotspot-compiler-dev mailing list