RFR: 8329726: Use non-short forward jumps in lightweight locking [v3]
Roman Kennke
rkennke at openjdk.org
Mon Apr 8 08:19:32 UTC 2024
> This turns a few short-jumps to long-jumps in x86 lightweight locking code paths. When running with -XX:+ShowMessageBoxOnError, MA::stop() generates more code and jccb is not sufficient to address this.
>
> Two of the jccb are in ASSERT path anyway. However, another is also in a product path. We *could* generate jccb or jcc conditionally on ShowMessageBoxOnError, however, I don't think it is worth the trouble. WDYT?
>
> Unfortunately, I could not make a simple test-case, because ShowMessageBoxOnError stops and waits on error, which would make jtreg time-out.
>
> Testing:
> - [x] manual test with dacapo as provided in the bug report
> - [ ] tier1
Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
Add test-case
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18657/files
- new: https://git.openjdk.org/jdk/pull/18657/files/025755b2..f6231d8f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18657&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18657&range=01-02
Stats: 38 lines in 1 file changed: 38 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/18657.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18657/head:pull/18657
PR: https://git.openjdk.org/jdk/pull/18657
More information about the hotspot-compiler-dev
mailing list